<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; ">i guess i never saw that as a problem... unless you are adding a ton of extra stuff to the native js object (which should be frowned upon anyway) it should be fine.<DIV><BR class="khtml-block-placeholder"></DIV><DIV>does it really matter if you have an extra empty var in the root of your flash movie?</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV><BR><DIV><DIV>On Oct 21, 2006, at 3:07 AM, Olivier Pichon wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"> <FONT face="Verdana">Can I make a small suggestion:<BR> <BR> When looping through the params or variables to write them out to the page (generating the html code), is it possible to check that the value is not a function?<BR> <BR> We tend to use several js utilities that augment the Object class (we use json.js, for instance, that adds the 'tojsonstring' to all objects). However, the functions added to the Object class get output as both a <param> tag and an an extra entry in the flashvars attribute value when the SWF HTML code is generated.<BR> <BR> getVariablePairs could simply be rewritten as:<BR> </FONT> <PRE>getVariablePairs: function(){
var variablePairs = new Array();
var key;
var variables = this.getVariables();
for(key in variables){
var value = variables[key];
if ( typeof value != 'function')
variablePairs.push(key +"="+ value);
}
return variablePairs;</PRE><FONT face="Verdana">Same for the 2 portions of code in getSWFHTML() that write the params.<BR> <BR> Best regards,<BR> <BR> Olivier</FONT><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">_______________________________________________</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">SWFObject mailing list</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="mailto:SWFObject@lists.deconcept.com">SWFObject@lists.deconcept.com</A></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="http://lists.deconcept.com/listinfo.cgi/swfobject-deconcept.com">http://lists.deconcept.com/listinfo.cgi/swfobject-deconcept.com</A></DIV> </BLOCKQUOTE></DIV><BR></DIV></BODY></HTML>